National-Forestry-Authority / brms

1 stars 1 forks source link

CFR: Revisions #27

Open ygoex opened 1 year ago

ygoex commented 1 year ago

Log of actions taken (dated / time-stamped). This is not a field we need to use the revision log. The revision notes need to be mandatory.

We may need the Diff module.

This is an important feature to be added.

pcambra commented 1 year ago

@Yash621 is the diff module added?

Yash621 commented 1 year ago

@pcambra not yet, I implemented the same functionality using a lighter module, @ygoex said she will discuss with you if we need it, if yes i can create a seperate PR for it

pcambra commented 1 year ago

@Yash621 somehow I don't see this on https://brms.cambrico.net/node/add/central_forest_reserve?destination=/cfr after deployment, could you please check what might have happened? Thanks

Yash621 commented 1 year ago

@pcambra it's opening for me in local

Screenshot 2022-11-29 005754

are you referring about the functionality or the route itself is not opening ?

pcambra commented 1 year ago

@Yash621 this is the task to make the revision log mandatory and add the diff module.

Yash621 commented 1 year ago

@pcambra so yea the module that i added makes the revision log mandatory on every edit so when the node is created the first time the revision log is not mandatory as the first entry is by default for creating a node only

Yash621 commented 1 year ago

i can integrate some default revision log messages for create node if we don't want to keep it blank

pcambra commented 1 year ago

That makes total sense, thanks @Yash621

@LeScruf over to you for validation :)

ygoex commented 1 year ago

We need to add a prompt to let the user know that they need to add a log message in order to save the new changes.

ygoex commented 1 year ago

We need to add a minimum of characters to the log message: 15 characters.

peacog commented 1 year ago

Hi @LeScruf I've added the 15 character minimum. Please test on staging when you have a minute. Thanks

LeScruf commented 1 year ago

Thanks @peacog - working. Obviously we need to deploy an AI thingymajig to interogate the input to make sure it's not a random phrase or set of characters... but that's for another time.