search

National-Forestry-Authority / farmers

0 stars 1 forks source link

A flagged farmer log, once unflagged does not shift to the unflagged column #5

Open pcambra opened 3 years ago

pcambra commented 3 years ago

Page: http://dev-hsk.nfa-fmis.net/tree-farmer-overview?title=Test+farmer

"Unflagged and flagged farmer logs should be organised under their respective columns"

pcambra commented 3 years ago

@marcoscano I'm not sure if this is caused by a conflict but I can't make the list work quite right, it seems that when flagging/unflagging in the page, several logs are flagged at once and I don't see any changing columns, could you double check? Thanks!

marcoscano commented 3 years ago

@pcambra Can you provide more details to reproduce?

Just updated my local with master , but it still seems to be working for me:

https://user-images.githubusercontent.com/5372312/106366860-f08fa500-633e-11eb-857d-71e03bacd116.mov

pcambra commented 3 years ago

@marcoscano The behaviour on the video seems accurate, however I can't make it work in http://dev-hsk.nfa-fmis.net/tree-farmer-overview?title=Test+farmer

marcoscano commented 3 years ago

@pcambra I don't seem to have credentials to log in to http://dev-hsk.nfa-fmis.net/ , should I have? Thanks!

Just double-checking.. did you deploy the config changes from https://github.com/Cambrico/tree_farmer/pull/22/files as well?

LeScruf commented 3 years ago

This is not working as it should be: there should be two columns: 1. 'Flagged Farmer Logs' 2. 'Farmer Logs' When you 'flag' a farmer log it should move to column 1 ('Flagged Farmer Logs') and when you 'unflag' a log (because it's been addressed) it should revert to column 2 'Farmer Logs'.

The logic is that (in due course) a user will be able to be able to list all 'flagged farmer logs' (with additional filters as needed) as part of the reports functionality to address these logs (issues) as a priority. In addition, when visiting an individual farmer record, a user can immediately see if there is a pressing issue with the particular farmer that requires attention.