NationalBankBelgium / stark

Modern client-side Web application framework based on Angular, Angular Material / Material Design, TypeScript, Redux, RxJS, ...
https://stark.nbb.be
Other
55 stars 23 forks source link

An in-range update of conventional-changelog-cli is breaking the build 🚨 #1432

Closed greenkeeper[bot] closed 4 years ago

greenkeeper[bot] commented 4 years ago

The devDependency conventional-changelog-cli was updated from 2.0.26 to 2.0.27.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

conventional-changelog-cli is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details - ❌ **continuous-integration/travis-ci/push:** The Travis CI build failed ([Details](https://travis-ci.org/NationalBankBelgium/stark/builds/609900083?utm_source=github_status&utm_medium=notification)).

Commits

The new version differs by 7 commits.

  • 741e907 Publish
  • 814f878 feat(conventional-changelog-core): provide facility to define gitExecOpts. (#480)
  • c522743 fix(conventional-commits-parser): add missing separator pipe to non tty parser (#546)
  • efdf3cb fix(conventional-commits-parser): add breaking change notes if header match breakingHeaderPattern (#544)
  • fe449f8 fix: revertPattern match default git revert format (#545)
  • e3c16e2 chore(conventional-changelog-core): stop using deprecated url.parse (#541)
  • a56e559 ci(travis): add node 12 to testing matrix (#542)

See the full diff

FAQ and help There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

greenkeeper[bot] commented 4 years ago

After pinning to 2.0.26 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.

christophercr commented 4 years ago

The issue was not related to this upgrade but to another separate issue (karma-typescript with prettier 1.19.x). After fixing that other issue, re-basing this branch and re-running the build, it succeeded.