NationalBankBelgium / stark

Modern client-side Web application framework based on Angular, Angular Material / Material Design, TypeScript, Redux, RxJS, ...
https://stark.nbb.be
Other
55 stars 23 forks source link

testing: e2e - add coverage reports for e2e tests #239

Open dsebastien opened 6 years ago

dsebastien commented 6 years ago

Links:

Mallikki commented 6 years ago

Hi guys,

I've been checking all those links and it seems that Grunt has not been updated since the beginning of 2017, and Istanbul is not maintained anymore (since 2016).

Is that an issue here?

Also, i've seen that link during my research: https://www.npmjs.com/package/protractor-e2e-coverage
This is a package that will measure e2e coverage and put the output in a file. It seems relevant but the latest version has been published also 3 years ago.

Should I go for Grunt, as it is the most recent package? Or for Istanbul, which seems more complete?

Edit: I'll put that issue on wait, as there are several problems with it:

There is an actual issue on Angular-CLI about e2e testcoverage: https://github.com/angular/angular-cli/issues/6286 but this seems a bit blocked - or at least on wait - as well (last answer - and not a one requiring this feature to be implemented - was a few months ago).

What should we do here?

pvdyck commented 6 years ago

FYI : https://github.com/edvlucas/angular-e2e-coverage

dsebastien commented 6 years ago

Great @pvdyck, thanks!

dsebastien commented 5 years ago

We can also investigate this project, as recommended by Minko: https://github.com/manfredsteyer/ngx-build-plus