Refactor/remove ngcli defaultproject usage

SuperITMan commented 5 months ago

PR Checklist

Please check if your PR fulfills the following requirements:

[X] The commit message follows our guidelines: https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#-commit-message-guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[X] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

stark-build is using the deprecated defaultProject property from the "angular.json" file in order to read values from the file.

Issue Number: N/A

What is the new behavior?

The usage of the defaultProject property has been replaced by the projectId provided by @angular-builders/custom-webpack.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

coveralls commented 5 months ago

coverage: 88.609%. remained the same when pulling 8c4a4d45b7f73de704f7355732867523ddf4cd5f on SuperITMan:refactor/remove-ngcli-defaultproject-usage into 9ae9447786da9160fae5bd79e3d5b370475b361b on NationalBankBelgium:master.

sonarcloud[bot] commented 5 months ago

Quality Gate passed

Issues
1 New issue

Measures
0 Security Hotspots
No data about Coverage
1.2% Duplication on New Code

See analysis details on SonarCloud

NationalBankBelgium / stark