NationalBankBelgium / stark

Modern client-side Web application framework based on Angular, Angular Material / Material Design, TypeScript, Redux, RxJS, ...
https://stark.nbb.be
Other
55 stars 23 forks source link

Feature/upgrade class validator #3759

Closed SuperITMan closed 4 months ago

SuperITMan commented 4 months ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

The current version of class-validator contains a critical vulnerability.

Issue Number: #3708

What is the new behavior?

A new StarkArrayIsValid() validation decorator + upgrade class-validator dependency.

Finally, the publicApp property has been deprecated in StarkAppConfig since it's not used.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
1.1% Duplication on New Code

See analysis details on SonarCloud

coveralls commented 4 months ago

Coverage Status

coverage: 88.385% (+0.05%) from 88.338% when pulling b6db64220ebb1051fd7cd63cb8efb59b89549874 on SuperITMan:feature/upgrade-class-validator into 3205bfc5765a2d76efafd3f81f5e303bc75a8318 on NationalBankBelgium:master.