search

NationalBankBelgium / stark

Modern client-side Web application framework based on Angular, Angular Material / Material Design, TypeScript, Redux, RxJS, ...
https://stark.nbb.be
Other
54 stars 23 forks source link

ui: table - fix Dutch translations for "select all" #3797

Open SuperITMan opened 1 month ago

SuperITMan commented 1 month ago

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[X] Bug report  
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

The current Dutch translation is incorrect.

https://github.com/NationalBankBelgium/stark/blob/836cc7947dc93a50d62d8e7f32d30fbdcccfe8a7/packages/stark-ui/src/modules/table/assets/translations/nl.ts#L34-L35

Expected behavior

It should be:

SELECT_ALL: "Selecteer alles",
SELECT_DESELECT_ALL: "Selecteer alles / Deselecteer alles",

Minimal reproduction of the problem with instructions

N/A

What is the motivation / use case for changing the behavior?

Improve translations.

Environment


Angular version: /
Stark version: 10.x & 12.x


Others: