NationalBankBelgium / stark

Modern client-side Web application framework based on Angular, Angular Material / Material Design, TypeScript, Redux, RxJS, ...
https://stark.nbb.be
Other
55 stars 23 forks source link

fix(stark-testing): replace `@npmcli/ci-detect` dependency by `ci-info` #3809

Closed mhenkens closed 4 months ago

mhenkens commented 4 months ago

ISSUES CLOSED: #3658

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

stark-testing is using @npmcli/ci-detect library in Karma in order to detect if it is running in a CI environment.

⚠️@npmcli/ci-detect has been deprecated.

Issue Number: #3658

What is the new behavior?

We use the new recommended library instead: ci-info

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

coveralls commented 4 months ago

Coverage Status

coverage: 88.822%. remained the same when pulling dc3eb8a1a0e21d43f25daebf6f5b216da4562fa1 on mhenkens:bugfix/3658 into a1fb423be32f3c668cf06bff6fb699b46befdf31 on NationalBankBelgium:master.