NationalBankBelgium / stark

Modern client-side Web application framework based on Angular, Angular Material / Material Design, TypeScript, Redux, RxJS, ...
https://stark.nbb.be
Other
55 stars 23 forks source link

fix(stark-core): enable correlation-id generation when `loggingFlushDisabled == true` #3810

Closed mhenkens closed 4 months ago

mhenkens commented 4 months ago

ISSUES CLOSED: #3620

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #3620

What is the new behavior?

The correlation-id is now generated even when the loggingFlush is disabled.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

coveralls commented 4 months ago

Coverage Status

coverage: 88.856% (+0.03%) from 88.822% when pulling 0aeece5fd5af5ec26323d3d09240b9cb9df8e33e on mhenkens:bugfix/3620 into 2d8aeadc1825773f8149ff5d9d94dc589965a5ed on NationalBankBelgium:master.