NationalBankBelgium / stark

Modern client-side Web application framework based on Angular, Angular Material / Material Design, TypeScript, Redux, RxJS, ...
https://stark.nbb.be
Other
54 stars 23 forks source link

fix(stark-core): fix support for URL query parameters #3811

Closed SuperITMan closed 1 month ago

SuperITMan commented 1 month ago

ISSUE CLOSED: #3766

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #3766

What is the new behavior?

Query params in URL are handled correctly.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

coveralls commented 1 month ago

Coverage Status

coverage: 88.859% (+0.003%) from 88.856% when pulling b2482b373fac4de9bf5f55ad06b13be64cb761c4 on SuperITMan:bugfix/fix-routing-service-3766 into a7cb51a8b5ccf71843aced9f756f50018b18d477 on NationalBankBelgium:master.

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
1.0% Duplication on New Code

See analysis details on SonarCloud