search

NationalGenomicsInfrastructure / anglerfish

Anglerfish - Nanopore reads from Illumina libraries
MIT License
2 stars 4 forks source link

Add UMI support #72

Closed remiolsen closed 8 months ago

remiolsen commented 9 months ago
remiolsen commented 9 months ago

@alneberg The last feature before release. I would like to merge this before #71 if you don't mind. I guess my solution to reconciling our code is to split the baby in half then to sew her back together again (if that analogy works). My point is that it's a bit ugly but it works.

remiolsen commented 8 months ago

Great work! This breaks the explore command a tiny bit for UMI:s. I've located the issue and I should be able to create a fix for it. Separate PR I guess. Your call if it should be included in this release or not. If I can fix it quickly I think it would make sense to include it.

I was thinking of doing a release on Friday, if you can't get a fix out in time it's not a huge deal.

Also I think this code, the adaptor handling parts, could do with simplifying or refactoring. For instance the separate I7 and I5 handling could be DRY'd up. But that's for another time.