NationalGenomicsInfrastructure / piper

A genomics pipeline build on top of the GATK Queue framework
9 stars 9 forks source link

To allow institution-specific setup #51

Closed biocyberman closed 9 years ago

biocyberman commented 9 years ago

I would like to suggest merging of the following two commits:

Commit aac74bce7e22

https://github.com/biocyberman/piper/commit/aac74bce7e22137e6fb7a539f21102c7ef5ebf3e

I created a 'config' directory at project base and moved three original files to 'config/upsala': globalConfig.sh globalConfig.xml uppmax_global_config.xml. I then modified setup.sh file to allow this syntax:

./setup.sh /path/to/install/piper institution /path/to/otherlibraries/lib NoGATKCompile

An example command is like this: ./setup.sh /space/system/piper afmd /space/system/lib nogatk

Which means:

  1. To install piper to /space/system/piper
  2. To pickup config files under config/afmd directory. Current possible choices are afmd and upsala, but more subdirectory for any new institution can be added.
  3. Register /space/system/lib to piper so it can look for additional library dependencies (If they are put there, of course)
  4. The fourth argument, whenever none-empty, will tell setup.sh not to download and compile GATK. This is nicer than commenting/uncommenting the function call.

Commit 704a1ac9d26cc686d This is an additional commit to remove dependency on GenomeAnalysisTK.jar. This is because Queue.jar already includes content of GenomeAnalysisTK.jar. Putting both of them together in lib causes warning about redundant packages found, such as the one about org.slf4j bindings.

https://github.com/biocyberman/piper/commit/704a1ac9d26cc686d460fd93dc9b551f6ced77f5

My commit tree looks a bit messy, I will try to keep them in good order from now on :)