NationalMuseumAustralia / Collection-API

The public web API of the National Museum of Australia
10 stars 0 forks source link

API returns 404 response to queries with no results #146

Closed Conal-Tuohy closed 4 years ago

Conal-Tuohy commented 5 years ago

An API query is a request for a resource which is a list of things which meet the search criteria. If nothing matches the criteria, then that list is empty, but it is not itself missing. The server should report that the resource (the empty list) does exist, using an HTTP 200 status.

Conal-Tuohy commented 5 years ago

Mark Raadgever from NLA confirms:

our harvester assumes that a 404 message indicates that there is problem with the harvest, so doesn’t see it as completed

Conal-Tuohy commented 5 years ago

Test on csapi-test.nma.gov.au