search

NationalMuseumAustralia / Collection-API

The public web API of the National Museum of Australia
10 stars 0 forks source link

Add creditline field #49

Closed staplegun closed 5 years ago

staplegun commented 6 years ago

From EMu RigCreditLine2 field.

staplegun commented 6 years ago

This is already available in crm:P67i_is_referred_to_by in CRM and acknowledgement in simple DC. The outstanding question is whether to include/exclude depending on the boolean in RigAcknowledgement (which currently is empty).

f27wood commented 6 years ago

This is one for Karen, but my understanding is that the credit line would be excluded if RigAcknowledgement equalled 'No". if empty or 'yes' then the creditline2 could be included. Currently RigAcknowledgement isn;t populated as no creditLine2 data has been entered if not OK to publish.

k1peterson commented 6 years ago

Fiona is correct. The creditline2 data is excluded if RigAcknowledgement equals 'No'. Creditline2 data is included if RigAcknowledgement equals 'Yes' or is empty. RigAcknowledgement is not populated at present but we are about to start doing so soon. It is more often likely that there will be no creditline2 data when the RigAcknowledgement is 'No' but not always the case, hence the need to have the logic.

staplegun commented 6 years ago

The logic of using RigAcknowledgement has been added, but there are no records using it yet.

The acknowledgement field is currently not searchable - its content is not 'about' the resource so could skew searches, e.g. many say "Donated through the Australian Government".

f27wood commented 6 years ago

That makes sense not to make it searchable. I will ask Karen to create a test record so we can test this.

staplegun commented 6 years ago

Actually, it can be searchable as acknowledgement=*, we just won't add it to the record-wide text=* field. I think that was the intention but got lost amongst all the mapping working.

f27wood commented 6 years ago

Ah okays yes I can see now that acknowledgement is a searchable field. And agreed that it doesn't need to be in the text wide search.

staplegun commented 6 years ago

To clarify, acknowledgement is a searchable field, except currently it isn't being populated - so that's an outstanding issue.

f27wood commented 6 years ago

Karen has created a test record so we can test the exclusion, irn 229042 Not yet in XML, but should be overnight.

staplegun commented 6 years ago

Outstanding issue that the acknowledgement field has not been made searchable.

However there also are no records in the EMu XML file (19 July) containing the field RigAcknowledgement.

staplegun commented 6 years ago

Added acknowledgement field in Solr. http://nma-dev.conaltuohy.com/object?limit=5&acknowledgement=*

staplegun commented 5 years ago

Added followup issue for the RigAcknowledgement boolean in #86.