Incomplete records in API

[SimmoK]

I've noticed some incomplete records in the API like https://data.nma.gov.au/object/45666. Seems to missing most of the info. Appears the same in API Explorer. See json response and the source EMu XMl for the record attached

[SimmoK]

PLs ignore i note the restricted now! Will close

[SimmoK]

Though will this be excluded from public search results?

[staplegun]

Records are OK to appear in the public API if they contain AcsAPI of Public or Public Restricted (the image is removed if AcsCCStatus isn't a CC or Public Domain).

So this record should be in the public API, but not sure why the other fields are missing (description, materials, parties, measurements, etc.). Maybe it accidentally got caught in the redaction process.

[Conal-Tuohy]

Check the SPARQL DESCRIBE query result to see if the data's there

[staplegun]

The full record is stored correctly in Fuseki DESCRIBE <http://data.nma.gov.au/object/45666#> - including production, materials, image, etc. This object record does NOT have a Piction image (just the above EMu image).

However the record is these fields in the internal API in both simple and JSON-LD formats. https://data.nma.gov.au/object/45666?apiKey=XXX&format=json-ld https://data.nma.gov.au/object/45666?apiKey=XXX&format=simple (The public API should at least include materials, etc. anyway.)

So it would appear to be an issue in the trix redaction step.

[Conal-Tuohy]

The bug was indeed in the redaction step. We were trying to slim down the description of objects which were aggregated in a narrative, leaving behind only a few key properties of those objects. However, when the main resource being described was itself an object, and it was part of a narrative, then that object's properties were being cut down, too. In reality we only ever wanted to redact the properties of objects if they were secondary objects which were just part of a narrative, and we never wanted to redact the properties of the primary object itself.

Fixed in https://github.com/NationalMuseumAustralia/Collection-API-ETL/commit/9bc498d62ccd1ffc30e0826510637cdaae780e43

[staplegun]

Works in production now

• has four materials and hasVersion in internal https://data.nma.gov.au/object/45666?apikey=XXX
• no image in public https://data.nma.gov.au/object/45666

[f27wood]

Example record tested AOK in prod, waiting for full ETL load to check other records.

[f27wood]

All seems AOK in prod, is there is a way to automate this testing to confirm?

[f27wood]

As discussed, closing this as confident it has been fixed for objects with narratives,.