NationalSecurityAgency / datawave

DataWave is an ingest/query framework that leverages Apache Accumulo to provide fast, secure data access.
https://code.nsa.gov/datawave
Apache License 2.0
563 stars 246 forks source link

Remove JMS queue between QueryMetricsBean and QueryMetricsWriter #2159

Closed billoley closed 9 months ago

billoley commented 1 year ago

After investigating the ongoing periodic timeouts while adding query metrics to the JMS queue and the resulting webserver deadlocks, it appears that there are deadlock issues in the JMS server reattach connection code (not our original issue, but found in testing), and the original timeouts might be due to the large message path through the JMS server.

It seems less error prone at this point to remove the JMS queue from between QueryMetricsBean and QueryMetricWriter and instead inject QueryMetricsWriter into QueryMetricsBean transferring the metrics via a LinkedBlockingQueue.

keith-ratcliffe commented 9 months ago

@billoley seems like this can be closed, but figured I should ask before mashing the close button