Improve query sort options and implementations

NationalSecurityAgency / datawave

DataWave is an ingest/query framework that leverages Apache Accumulo to provide fast, secure data access.

https://code.nsa.gov/datawave

Apache License 2.0

561 stars 243 forks source link

Improve query sort options and implementations #2515

Open apmoriarty opened 1 month ago

apmoriarty commented 1 month ago

consolidate and rename variables that control sorting query pre and post global index lookup
expanded test cases for both pre and post index sorting
reworked sort implementations

ivakegg commented 1 month ago

I had previously approved this, but since then this PR is showing a heck of a lot more changes than just the variable renaming. What happened here?

apmoriarty commented 1 month ago

I had previously approved this, but since then this PR is showing a heck of a lot more changes than just the variable renaming. What happened here?

Someone requested additional tests which exposed several cases where sorting was not behavior according to expectation.

ivakegg commented 2 weeks ago

I had previously approved this, but since then this PR is showing a heck of a lot more changes than just the variable renaming. What happened here?

Someone requested additional tests which exposed several cases where sorting was not behavior according to expectation.

Well you also added additional sorting mechanisms as well, not just test cases.

apmoriarty commented 2 weeks ago

Well you also added additional sorting mechanisms as well, not just test cases.

I have updated the title and description to reflect that this was not just an update to some test cases