search

NationalSecurityAgency / ghidra

Ghidra is a software reverse engineering (SRE) framework
https://www.nsa.gov/ghidra
Apache License 2.0
51.23k stars 5.84k forks source link

cant disasm e_bdnz - PowerPC32 VLE #103

Closed arkup closed 5 years ago

arkup commented 5 years ago

Describe the bug

Ghidra cant disassemble PowerPC32 VLE : 7A 20 FF F8 IDA prints e_bdnz

Expected behavior

IDA

seg000:00040296 7A 20 FF F8                 e_bdnz    loc_4028E

Ghidra (press F12)

        00040296 7a              ??         7Ah    z
        00040297 20              ??         20h     
        00040298 ff              ??         FFh
        00040299 f8              ??         F8h
ghost commented 5 years ago

For some reason within Ghidra/Processors/PPC/data/languages/ppc_vle.sinc the CC32(condition code) has the "z" and "nz" case commented-out. I think it's possible these should be changed to "dz" and "dnz" and uncommented.

arkup commented 5 years ago

@gnooby22 yeah that seems to work, thanks!

ryanmkurtz commented 5 years ago

This will be fixed in our next release.