Some miss typo in idaxml.py file

NationalSecurityAgency / ghidra

Ghidra is a software reverse engineering (SRE) framework

https://www.nsa.gov/ghidra

Apache License 2.0

51.14k stars 5.83k forks source link

Some miss typo in idaxml.py file #2352

Open HongThatCong opened 4 years ago

HongThatCong commented 4 years ago

Describe the bug Ghidra v9.1.2 file idaxml.py in /IDAPro/Python/7xx/python/ Line 3099: idc.set_member_cmt(mbr, regcmt.text, False) Line 3013: idc.set_member_cmt(mbr, rptcmt.text, True)

Should change to: ida_struct.set_member_cmt(mbr, regcmt.text, False) and: ida_struct.set_member_cmt(mbr, rptcmt.text, True)

Best regards, HTC

HongThatCong commented 4 years ago

Also idaxml.py file: Line 714: demangled == None Should be: demangled = None

HongThatCong commented 4 years ago

Also idaxml.py file: Line 2383: [segstr, offset_str] = string.split(addrstr,':') Should be: [segstr, offset_str] = addrstr.split(':') Because of string.split is a deprecated function, will be removed in Python 3