Open hadess opened 2 years ago
I'll add this to my queue, but just to warn you, 10.1 is frozen at this point so a potential change to this code will not make it in that release.
I'll add this to my queue, but just to warn you, 10.1 is frozen at this point so a potential change to this code will not make it in that release.
I'm going to have to figure out how to build this at some point, because if you're not testing the software in a Flatpak, and I only test it when it's already released, the feedback cycle is always going to be a bit too long...
Yes, you don't want to rely on us to be testing each release on Flatpak, we don't have the resources for that. I recommend that you fork the Ghidra project and make a branch with the changes needed to get Ghidra working 100% correct in your environment, and then submit a pull-request so we can consider putting the changes in the next release.
Follow-up to https://github.com/NationalSecurityAgency/ghidra/issues/3377 with
ghidra_10.1-BETA_PUBLIC_20211116
It seems that a regression might have snuck in that results in a problem unpacking the
gdt
packed database.When running "Auto analysis":
And when installed in /opt outside a Flatpak:
Note that in Flatpak, the directory for the packed-db-cache exists, but is empty, and in its parent:
Same file but when outside
/opt
and Flatpak:My guess is that, again,
0
is being used as a special case: https://github.com/NationalSecurityAgency/ghidra/blob/master/Ghidra/Framework/FileSystem/src/main/java/ghidra/framework/store/db/PackedDatabaseCache.java#L161and the database never unpacked because it didn't change since
0
? https://github.com/NationalSecurityAgency/ghidra/blob/master/Ghidra/Framework/FileSystem/src/main/java/ghidra/framework/store/db/PackedDatabase.java#L558-L590