search

NationalSecurityAgency / ghidra

Ghidra is a software reverse engineering (SRE) framework
https://www.nsa.gov/ghidra
Apache License 2.0
50.83k stars 5.8k forks source link

Icons in .rsrc are in wrong color #436

Open jrileyBU opened 5 years ago

jrileyBU commented 5 years ago

Describe the bug The graphic for the first icon in the .rsrc section is rendered correctly. The remaining five have blue where there should be yellow. To Reproduce Steps to reproduce the behavior:

  1. Use CodeBrowser to disassemble code
  2. Use Function Trees to display .rsrc section
  3. Scroll down to part of .rsrc with icons.
  4. See error

Expected behavior Icons should be correctly colored.

Screenshots image

Attachments If applicable, please attach any files that caused problems or log files generated by the software.

Environment (please complete the following information):

Additional context Here's the screenshot again:

Ghidra-ICONS

Add any other context about the problem here.

ryanmkurtz commented 5 years ago

I looked at a bunch of examples and didn't see any color inconsistencies. How certain are you that the icon should not be blue?

jrileyBU commented 5 years ago

I’m pretty confident. I looked at the icons in two other tools (CFF Explorer and Resource Hacker) and they both came up yellow.

The program that’s attached is the one that caused the problem. I wrote it and used Resource Hacker for the icons which is the other reason I believe the icons should be yellow.

Thanks for checking this out.

From: Ryan Kurtz notifications@github.com Sent: Wednesday, April 17, 2019 12:31 PM To: NationalSecurityAgency/ghidra ghidra@noreply.github.com Cc: Riley, John H jriley@bloomu.edu; Author author@noreply.github.com Subject: Re: [NationalSecurityAgency/ghidra] Icons in .rsrc are in wrong color (#436)

I looked at a bunch of examples and didn't see any color inconsistencies. How certain are you that the icon should not be blue?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_NationalSecurityAgency_ghidra_issues_436-23issuecomment-2D484164434&d=DwMCaQ&c=HS1CjnFyfzCL6mp0nkGYYw&r=TQADd5plTxa06HfBcb_1llKoyNKn0WGRnqp17DV_XpQ&m=karTIjnV6d6Shk4hm3N46APLGgvM1TvmGjLkISfvqWM&s=yz7Av1Jm0UmuV6UQ__BbK0iBN17sO5I3EHzv1h9VLno&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AvW-2DCPqhX-5FiwX9-5Fls-2DSkeGwEyOcsjVsUks5vh0w9gaJpZM4cw3gS&d=DwMCaQ&c=HS1CjnFyfzCL6mp0nkGYYw&r=TQADd5plTxa06HfBcb_1llKoyNKn0WGRnqp17DV_XpQ&m=karTIjnV6d6Shk4hm3N46APLGgvM1TvmGjLkISfvqWM&s=bO50x2sDFo3a5Lb6OrpN9gQX45cfFB7M101mcB586-U&e=.

jrileyBU commented 5 years ago

I think this is another example where the colors of icons are wrong. This a program from a previous version of Sysinternals which blue screens a system. Some of the “blue screens” are red. I checked this with CFF Explorer and Resource Hacker.

From: Ryan Kurtz notifications@github.com Sent: Wednesday, April 17, 2019 12:31 PM To: NationalSecurityAgency/ghidra ghidra@noreply.github.com Cc: Riley, John H jriley@bloomu.edu; Author author@noreply.github.com Subject: Re: [NationalSecurityAgency/ghidra] Icons in .rsrc are in wrong color (#436)

I looked at a bunch of examples and didn't see any color inconsistencies. How certain are you that the icon should not be blue?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_NationalSecurityAgency_ghidra_issues_436-23issuecomment-2D484164434&d=DwMCaQ&c=HS1CjnFyfzCL6mp0nkGYYw&r=TQADd5plTxa06HfBcb_1llKoyNKn0WGRnqp17DV_XpQ&m=karTIjnV6d6Shk4hm3N46APLGgvM1TvmGjLkISfvqWM&s=yz7Av1Jm0UmuV6UQ__BbK0iBN17sO5I3EHzv1h9VLno&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AvW-2DCPqhX-5FiwX9-5Fls-2DSkeGwEyOcsjVsUks5vh0w9gaJpZM4cw3gS&d=DwMCaQ&c=HS1CjnFyfzCL6mp0nkGYYw&r=TQADd5plTxa06HfBcb_1llKoyNKn0WGRnqp17DV_XpQ&m=karTIjnV6d6Shk4hm3N46APLGgvM1TvmGjLkISfvqWM&s=bO50x2sDFo3a5Lb6OrpN9gQX45cfFB7M101mcB586-U&e=.

ryanmkurtz commented 5 years ago

Thanks for the additional info...we'll take a look. Perhaps it's a difference in how we are handling PNG vs IconRes.