NationalSecurityAgency / ghidra

Ghidra is a software reverse engineering (SRE) framework
https://www.nsa.gov/ghidra
Apache License 2.0
51.86k stars 5.89k forks source link

Add support for vxworks 5.0 in builtin script `VxWorksSymTab_Finder.java` #4507

Closed fenugrec closed 1 year ago

fenugrec commented 2 years ago

Describe the solution you'd like It should be a simple matter of adding a case in private VxSymbol getVxSymbolClass(int type) . Vxworks 5.3 has a slightly different struct SYMBOL from the other versions already supported.

Describe alternatives you've considered I temporarily cannot test /implement this until I can run scripts (need to resolve unrelated issues)

Additional context From symbol.h revision "02c,22sep92" , in a release tagged 5.3 (15mar96) :

typedef struct          /* SYMBOL - entry in symbol table */
    {
    SL_NODE nameHNode;  /* hash node (must come first) */
    char    *name;      /* pointer to symbol name */
    char    *value;     /* symbol value */
    UINT16  group;      /* symbol group */
    SYM_TYPE    type;       /* symbol type */
    } SYMBOL;

SYM_TYPE defaults to a signed char, int8

fenugrec commented 2 years ago

Edit - vx 5.3 should alreadby be handled properly . My ROM was actually based on vx 5.0 ! Submitting a PR shortly.