search

NationalSecurityAgency / ghidra

Ghidra is a software reverse engineering (SRE) framework
https://www.nsa.gov/ghidra
Apache License 2.0
50.85k stars 5.8k forks source link

win pdb: don't override PlatformToolset #6610

Closed shuffle2 closed 3 months ago

shuffle2 commented 4 months ago

The msvc toolset version recently bumped to 14.40.x. See https://devblogs.microsoft.com/cppblog/msvc-toolset-minor-version-number-14-40-in-vs-2022-v17-10/ Ghidra was assuming the msvc toolset version would match the PlatformToolset version (which indicates binary compatibility), which is not correct. PlatformToolset specified on msbuild commandline was overriding the value in the vcxproj, and not acting as a "default" value. Just remove the explicit passing, it's handled by the vcxproj already.

fixes windows build

shuffle2 commented 4 months ago

To clarify need for this: latest visual studio install will default to msvc toolset version VCToolsVersion=14.40.33807, but it is still PlatformToolset v143. The current logic in ghidra would attempt to use v144 (which doesn't exist).

ryanmkurtz commented 3 months ago

Thanks, I'm reproducing this. Will test your PR more thoroughly tomorrow.