Build failed after release 9911db98

[Wall-AF]

Describe the bug Just tried building the latest commit (9911db98) and the pdb solution now fails.

> Configure project :
Gradle: 8.5
Python3 command:  py (version 3.12)
Python3 pip version: 24.0
OS: Windows 11
Arch: amd64 (gradle: x86-64)
Using platform: win_x86_64
Searching for latest Visual Studio and required components...
  -> Installation Directory: C:\Program Files\Microsoft Visual Studio\2022\Community
  -> VCTools Version (default): 14.40.33807
  -> SDK Directory (default): C:\Program Files (x86)\Windows Kits\10\
  -> SDK Version (default): 10.0.19041.0
  -> SDK Version (override): N/A

> Task :PDB:win_x86_64PDBMake FAILED
Executing: msbuild "D:\GIT_Sources\Ghidra.Latest\ghidra\Ghidra\Features\PDB\src\pdb\pdb.sln" /p:Configuration=Release /p:PlatformToolset=v144 /p:WindowsTargetPlatformVersion=10.0.19041.0

D:\GIT_Sources\Ghidra.Latest\ghidra\Ghidra\Features\PDB>call "C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Auxiliary\Build\vcvarsall.bat" x86_amd64
**********************************************************************
** Visual Studio 2022 Developer Command Prompt v17.10.2
** Copyright (c) 2022 Microsoft Corporation
**********************************************************************
[vcvarsall.bat] Environment initialized for: 'x86_x64'
MSBuild version 17.10.4+10fbfbf2e for .NET Framework
Build started 14/06/2024 12:13:19.

Project "D:\GIT_Sources\Ghidra.Latest\ghidra\Ghidra\Features\PDB\src\pdb\pdb.sln" on node 1 (default targets).
ValidateSolutionConfiguration:
  Building solution configuration "Release|x64".
Project "D:\GIT_Sources\Ghidra.Latest\ghidra\Ghidra\Features\PDB\src\pdb\pdb.sln" (1) is building "D:\GIT_Sources\Ghidra.Latest\ghidra\Ghidra\Features\PDB\src\pdb\pdb.vcxproj" (2) on node 1 (default targets).
C:\Program Files\Microsoft Visual Studio\2022\Community\MSBuild\Microsoft\VC\v170\Microsoft.CppBuild.targets(456,5): error MSB8020: The build tools for v144 (Platform Toolset = 'v144') cannot be found. To build using the v144 build tools, please install v144 build tools.  Alternatively, you may upgrade to the current Visual Studio tools by selecting the Project menu or right-click the solution, and then selecting "Retarget solution". [D:\GIT_Sources\Ghidra.Latest\ghidra\Ghidra\Features\PDB\src\pdb\pdb.vcxproj]
Done Building Project "D:\GIT_Sources\Ghidra.Latest\ghidra\Ghidra\Features\PDB\src\pdb\pdb.vcxproj" (default targets) -- FAILED.
Done Building Project "D:\GIT_Sources\Ghidra.Latest\ghidra\Ghidra\Features\PDB\src\pdb\pdb.sln" (default targets) -- FAILED.

Build FAILED.

"D:\GIT_Sources\Ghidra.Latest\ghidra\Ghidra\Features\PDB\src\pdb\pdb.sln" (default target) (1) ->
"D:\GIT_Sources\Ghidra.Latest\ghidra\Ghidra\Features\PDB\src\pdb\pdb.vcxproj" (default target) (2) ->
(PrepareForBuild target) ->
  C:\Program Files\Microsoft Visual Studio\2022\Community\MSBuild\Microsoft\VC\v170\Microsoft.CppBuild.targets(456,5): error MSB8020: The build tools for v144 (Platform Toolset = 'v144') cannot be found. To build using the v144 build tools, please install v144 build tools.  Alternatively, you may upgrade to the current Visual Studio tools by selecting the Project menu or right-click the solution, and then selecting "Retarget solution". [D:\GIT_Sources\Ghidra.Latest\ghidra\Ghidra\Features\PDB\src\pdb\pdb.vcxproj]

    0 Warning(s)
    1 Error(s)

Time Elapsed 00:00:00.12

FAILURE: Build failed with an exception.

Viisual Studio is kept up-to-date and is currently 2022, Command Prompt v17.10.2

Environment (please complete the following information):

• OS: Windows 11
• Java Version: 17.0.3.1
• Ghidra Version: 11.1
• Ghidra Origin: locally built (9911db98)

Additional context Built the actual project from within Visual Studio 2022 with no issues!

[jobermayr]

I assume you need already merged https://github.com/NationalSecurityAgency/ghidra/pull/6610

[Wall-AF]

@jobermayr thanks for that. I knew there'd been something regarding this, but I missed it, duh! I also needed to upgrade both Gradle and Java!