NationalSecurityAgency / ghidra

Ghidra is a software reverse engineering (SRE) framework
https://www.nsa.gov/ghidra
Apache License 2.0
51.13k stars 5.82k forks source link

Analyzer Copyright Header #672

Closed astrelsky closed 5 years ago

astrelsky commented 5 years ago

I am putting the finishing touches on a GNU RTTI Analyzer which I intend to submit a pull request for. I already have them there but wished to ask before I finish up. Is the following header required to be placed at the start of every file?

/* ###
 * IP: GHIDRA
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 * 
 *      http://www.apache.org/licenses/LICENSE-2.0
 * 
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

If there isn't interest in the analyzer I can release it as a stand alone plugin. However it would be useful to have the GNU Demangler apply the datatypes as opposed to undefined byte arrays.

I am mainly asking beforehand to cover myself in the event that it ends up being released as a stand alone plugin.

ryanmkurtz commented 5 years ago

If we accept a pull request, our internal process will add the header so you don't have to worry about it.

astrelsky commented 5 years ago

@ryanmkurtz

Ok thank you. I hope to have the pull request submitted by the end of the week.