NationalSecurityAgency / ghidra

Ghidra is a software reverse engineering (SRE) framework
https://www.nsa.gov/ghidra
Apache License 2.0
50.85k stars 5.8k forks source link

Fix null exception in PropagateExternalParametersScript.java #6841

Closed leechristensen closed 3 weeks ago

leechristensen commented 1 month ago

Added a null check to account for when an address refers to a to a pointer. The screenshots highlight two cases where this occurs in msinfo32.exe on Windows due to MFC/CFG addresses.

image

image

ghidra007 commented 1 month ago

@leechristensen Did you add the change to use the full package in the print so you don't have to organize imports after uncommenting it?

leechristensen commented 1 month ago

Yep, but happy to change things if wanted. Could split it across a couple lines if wanted or add the import

ghidra007 commented 1 month ago

When I review it I'll update to add a define option so that the import is always there.