NationalSecurityAgency / timely

Accumulo backed time series database
https://code.nsa.gov/timely/
Apache License 2.0
377 stars 108 forks source link

Performance issue #203

Closed matthpeterson closed 4 years ago

matthpeterson commented 4 years ago

Jstacking a tserver running a scan revealed that this line is throwing a NoSuchMethodException and not logging anything.

https://github.com/NationalSecurityAgency/timely/blob/4b11b3d50f3a21c3cd2c603ff0bf1fd170b2d773/client/src/main/java/timely/model/ObjectSizeOf.java#L94

For the DownsampleIterator.hasTop code path, the object will always be a HashMap and will never have this method.

It seems that if object is not an instance of ObjectSizeOf, it should not attempt to find and invoke a "sizeInBytes" method.