search

NativeDesign / python-tmcl

TMCL Serial interface to Trinamic Stepper Motors
MIT License
19 stars 9 forks source link

Checksum and some minor updates #1

Closed cweickhmann closed 7 years ago

cweickhmann commented 7 years ago

Please consider these changes to be incorporated in your repo. I've used the library with a TMCM 310 controller and realised that the checksum mechanism doesn't work with that controller. I first thought this was because of the controller. But an erratic check of some newer Trinamic controllers revealed that the checksum is still calculated based on 8bit additions. So the new checksum should work as expected.

Also, I found the naming scheme of module, address and motor a bit confusing.

I will start to add some documentation to the respective functions. I think this might help other users :)

Bests! Christian

cweickhmann commented 7 years ago

Thanks for the feedback, Alan! Note to self: Be careful with adding "notes to self" to the repo ^^

I have tried to make the deprecation of get_motor visible in a pythonic way without adding dependencies.