NativeInstruments / ni-media

NI Media is a C++ library for reading and writing audio streams.
MIT License
244 stars 34 forks source link

Feature/add code coverage #28

Closed benvenutti closed 5 years ago

benvenutti commented 5 years ago

Hey there, here is a small contribution adding code coverage for ni-media. Here is an example of the generated report: https://codecov.io/gh/benvenutti/ni-media/branch/feature%2Fadd-code-coverage

Changes:

You will notice that the PCM tests were disabled for the coverage build. For proper coverage, optimization has to be turned off. This was causing the PCM tests to run for a really long time and Travis has a limit of 10 minutes to run without any outputs. So this causing the actual coverage build to fail. Here is an example of the problem on Travis: https://travis-ci.org/benvenutti/ni-media/jobs/522984435

@marcrambo, you will have to create an account on codecov.io and enable ni-media there. Then, once the PR triggers the build, you will get the first report in your codecov.io. There you can get the correct badge URL to your repo. We then need to update the URLs in the README file in this PR, so the repo points to its respective reports.

codecov-io commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@7365043). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #28   +/-   ##
=========================================
  Coverage          ?   86.93%           
=========================================
  Files             ?       94           
  Lines             ?     1745           
  Branches          ?        0           
=========================================
  Hits              ?     1517           
  Misses            ?      228           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7365043...3c7cc9f. Read the comment docs.