NativeInstruments / ni-media

NI Media is a C++ library for reading and writing audio streams.
MIT License
244 stars 34 forks source link

Added CI using Github Actions #55

Closed ni-nkozlowski closed 2 years ago

ni-nkozlowski commented 2 years ago

As part of our migration from our internal build/CI system.

codecov[bot] commented 2 years ago

Codecov Report

Merging #55 (463b4b8) into master (5f9dd55) will decrease coverage by 3.08%. The diff coverage is 43.75%.

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
- Coverage   86.18%   83.10%   -3.09%     
==========================================
  Files          96       82      -14     
  Lines        1853     2024     +171     
==========================================
+ Hits         1597     1682      +85     
- Misses        256      342      +86     
Impacted Files Coverage Δ
audiostream/inc/ni/media/audio/stream_info.h 100.00% <ø> (ø)
audiostream/inc/ni/media/iostreams/positioning.h 85.71% <ø> (ø)
audiostream/src/ni/media/audio/source_impl.h 78.57% <0.00%> (-21.43%) :arrow_down:
audiostream/src/ni/media/iostreams/device/custom.h 0.00% <0.00%> (ø)
...udiostream/test/ni/media/audio/istream_read.test.h 99.14% <ø> (-0.86%) :arrow_down:
audiostream/src/ni/media/audio/ifstream.cpp 55.26% <3.22%> (-39.03%) :arrow_down:
audiostream/src/ni/media/audio/stream_info.cpp 72.72% <42.85%> (-5.54%) :arrow_down:
audiostream/src/ni/media/audio/aiff/aiff_source.h 67.85% <100.00%> (-0.07%) :arrow_down:
audiostream/src/ni/media/audio/flac/flac_source.h 84.89% <100.00%> (-0.51%) :arrow_down:
audiostream/src/ni/media/audio/ogg/ogg_source.h 90.47% <100.00%> (+0.60%) :arrow_up:
... and 94 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dcceb7a...463b4b8. Read the comment docs.

ni-nkozlowski commented 2 years ago

We can ignore the codecov failures - we didn't add tests that extended the added api from the last update so it makes sense that there's a reduction of coverage.

I guess going forward we should make sure that the code coverage doesn't go down.