[cmake] respect unity build option

NativeInstruments / ni-media

NI Media is a C++ library for reading and writing audio streams.

MIT License

235 stars 34 forks source link

[cmake] respect unity build option #61

Closed lkotsonis closed 7 months ago

lkotsonis commented 1 year ago

If you now use ni-media as a subproject, you can add

option(NIMEDIA_UNITY_BUILDS OFF)

to disable unity builds if needed.

ni-mheppner commented 1 year ago

Hi there, thanks for your contribution! The NIMEDIA_UNITY_BUILDS option so far has only been defined for the flavor of the library that we use internally, i.e. when NIMEDIA_OPEN_SOURCE was OFF. In the main cmake file, please move the definition of the option to the top section, below the other top level options, so that it is visible to open source clients, too. Other than that the change looks good to me.

ni-mheppner commented 7 months ago

The proposed change has been integrated here, alongside other changes in the cmake files. Thanks again, closing this one.