search

NativeInstruments / ni-media

NI Media is a C++ library for reading and writing audio streams.
MIT License
235 stars 34 forks source link

Fast PCM Encoding #72

Open FalconPDX opened 5 months ago

FalconPDX commented 5 months ago

Uses the pcm library to encode a range instead of each element in a range. Makes encoding much faster.

This is a first of three different packages - starting off with the smallest. The other two (refactor of the ofstream interface + FLAC encoding) will come at a later time in the form of a "stacked PR". This gives users a chance to try out the individual pieces and potentially find issues quicker at the cost of repeated testing.

The other two PRs: ofstream refactor: https://github.com/FalconPDX/ni-media/pull/3 FLAC encoding: https://github.com/FalconPDX/ni-media/pull/4

codecov[bot] commented 5 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (89eb1e3) 83.10% compared to head (f10b034) 83.00%.

Files Patch % Lines
audiostream/inc/ni/media/audio/ostream.h 83.33% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #72 +/- ## ========================================== - Coverage 83.10% 83.00% -0.10% ========================================== Files 82 82 Lines 2024 2030 +6 ========================================== + Hits 1682 1685 +3 - Misses 342 345 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.