NativePHP / laravel

Laravel wrapper for the NativePHP framework
https://nativephp.com
MIT License
3.2k stars 166 forks source link

public/icon.png not being used for `php artisan native:build` #388

Open DeanWard opened 1 month ago

DeanWard commented 1 month ago

What were you trying to do?

Build application for distribution to users

What happened?

The app was built and signed but it uses the default NativePHP icon

How to reproduce the bug

Add a PNG icon.png to your public folder and run php artisan native:build

Package Versions

{
  "installed": [
    {
      "name": "nativephp/electron",
      "direct-dependency": true,
      "homepage": "https://github.com/nativephp/electron",
      "source": "https://github.com/NativePHP/electron/tree/0.7.3",
      "version": "0.7.3",
      "description": "Electron wrapper for the NativePHP framework.",
      "abandoned": false
    },
    {
      "name": "nativephp/laravel",
      "direct-dependency": false,
      "homepage": "https://github.com/nativephp/laravel",
      "source": "https://github.com/NativePHP/laravel/tree/0.5.7",
      "version": "0.5.7",
      "description": "Laravel wrapper for the NativePHP framework.",
      "abandoned": false
    },
    {
      "name": "nativephp/php-bin",
      "direct-dependency": false,
      "homepage": "https://nativephp.com",
      "source": "https://github.com/NativePHP/php-bin/tree/0.5.4",
      "version": "0.5.4",
      "description": "PHP binaries used by the NativePHP framework",
      "abandoned": false
    }
  ]
}

PHP Version

8.2.0

Laravel Version

11.0

Node Version

20.10.0

Which operating systems have you seen this occur on?

macOS

OS version

macos 15.0

Notes

/vendor/nativephp/electron/resources/js/resources/icon.png has the correct icon file (my icon) but after build the app has the default icon. I've clean my icon cache in macos. The correct icon is used for php artisan native:serve.

simonhamp commented 23 hours ago

This is coming in nativephp/electron#106 (see this line)