NativeScript / android-dts-generator

A tool that generates TypeScript declaration files (.d.ts) from Jars
90 stars 23 forks source link

fix: wrap invalid JS property names in quotes #72

Closed mukaschultze closed 2 years ago

mukaschultze commented 2 years ago

Some libs (e.g., okhttp) have methods with names that generate invalid typescript code, this PR fixes this by wrapping invalid fields and methods names in quotes

Example:

-       public -deprecated_proxy(): java.net.Proxy;
+       public "-deprecated_proxy"(): java.net.Proxy;
cla-bot[bot] commented 2 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. CLA has not been signed by users: @mukaschultze. After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

mukaschultze commented 2 years ago

@cla-bot check

cla-bot[bot] commented 2 years ago

The cla-bot has been summoned, and re-checked this pull request!