Closed dev4s closed 4 years ago
Thank you very much!!!
I have tested this PR with several apps; and it does appear to restore debugging ability with the --debug-brk
command. Technically the --debug-brk
command SHOULD be breaking on the very first line of JS code; but this does fix the issue with it crashing out. So this is a awesome step in fixing the whole issue. We will have to figure out why the --debug-brk command isn't breaking on the first line of code still, but that can be a separate PR. Fixing Crashes is a good thing. :grinning:
Environment
Describe the bug The system doesn't break on the 'debugger'' line when set on main.ts. and shows the message: 'can't connect through WebSocket'.
To Reproduce
Expected behavior
Sample project
Additional context I've set on the main.ts the breakpoint by using the 'debugger' (Debug CLI) option. After that I've run the command specified for debugging, I couldn't connect (at least that was what chrome devtools was showing). Some couple of tries later I've said enough and started to debug the android runtime by using one of your guidelines regarding debugging starting scripts in android-runtime (Debug android runtime), found the problem with the ShouldBreak method (it couldn't handle the scope with the isolate_) and also with getDocument method (The document is empty as it isn't loaded yet, I think) . To be honest, I'm not a specialist regarding C++ and Java, I'm experienced mostly in C# and some of the JavaScript.