NativeScript / android

NativeScript for Android using v8
https://docs.nativescript.org/guide/android-marshalling
Apache License 2.0
523 stars 134 forks source link

console.log should not call object methods #1693

Open jerbob92 opened 2 years ago

jerbob92 commented 2 years ago

Environment Provide version numbers for the following components (information can be retrieved by running tns info in your project folder or by inspecting the package.json of the project):

Describe the bug When an object contains a toString or toJSON method, and you print that object through console.log, it will automatically call that function. This is very different from what Chrome console.log does and may cause confusing behavior. For example: The NativeScript HTTP client returns an object with a property called content that contains an object with a to toJSON method, when you console.log the return object, it will automatically call that toJSON method, while it might not even be JSON, causing the console.log to fail with a weird error from JSON.parse, like Unexpected end of JSON input.

To Reproduce

const randomVar = "test123";
const obj = {
    toJSON: () => "toJSON => this should not be logged " + randomVar
};

console.log(obj);

Expected behavior I think it should print something like:

{
  "toJSON": ƒ
}

Or, it should catch any errors that happen during the format, and then fall back to it's normal behavior (going to toString, or not printing the property at all). It should not be breaking off the whole console.log and return the exception.

Additional context Output when doing something like this in Chrome: image

Output when doing something like this in NS: image

When causing an error inside the function with:

const obj = {
    toJSON: () => JSON.parse("fakejson")
};

console.log(obj);

In Chrome: image

In NS: image