NativeScript / android

NativeScript for Android using v8
https://docs.nativescript.org/guide/android-marshalling
Apache License 2.0
523 stars 134 forks source link

8.2 release breaks 8.1.x builds due to a bug in the Nativescript CLI #1706

Closed bytelabsco closed 2 years ago

bytelabsco commented 2 years ago

Environment Provide version numbers for the following components (information can be retrieved by running tns info in your project folder or by inspecting the package.json of the project):

Describe the bug In current (8.1.x) versions of the nativescript CLI, a bug exists where the Gradle version is never actually pulled from the current platform (in this case @nativescript/android). You can see this in the 8.1.5 tagged version of the nativescript-cli

The projectRuntimeVersion is looked up, but nothing is ever done with it to set runtimeGradleVersions, so it falls through to the next if block to look up the latest runtime. It will then run the command npm view @nativescript/android@<whatever version> gradle --json to get the appropriate gradle info. You can see that this behavior has been fixed in the master version of nativescript-cli, but has not been released.

However, in 8.2.0 of @nativescript/android, the gradle property was replaced with version-info breaking any builds that are using the current version of the nativescript cli.

To Reproduce Create a project using Nativescript CLI 8.1.5. Use @nativescript/android 8.1.x. Try to build it.

Expected behavior In the interim, the gradle propery should still exist as a fallback for 8.1.x CLI users

a92c commented 2 years ago

news? We need fast feedback. Thank you

rigor789 commented 2 years ago

Update your CLI - should be backwards compatible and fix the issue.

See thread here: https://github.com/NativeScript/NativeScript/issues/9814#issuecomment-1062928925