NativeScript / android

NativeScript for Android using v8
https://docs.nativescript.org/guide/android-marshalling
Apache License 2.0
518 stars 136 forks source link

ObjectManager improvements: unused code removal, consolidation #1769

Closed ptomato closed 10 months ago

ptomato commented 1 year ago

Description

This PR contains some improvements to ObjectManager that I made while working on the port to CPPGC. It consists mostly of removal of unused features and dead code (the static analysis of Android Studio is really helpful here); the less code there is in ObjectManager, the less has to be ported to work with CPPGC. :smile:

Please do double-check the removed unused code to make sure that it is supposed to be unused; it's also possible that something was made dead code by accident, and is actually still supposed to be used somewhere!

Best reviewed commit by commit. Further descriptions of each commit are in the individual commit messages.

Related Pull Requests

None.

Does your pull request have unit tests?

This PR removes the unit tests that were only run in "full" marking mode, because that mode no longer exists. All other functionality should remain unchanged, so no new unit tests added.