feat: redesigned error activity ui

[ammarahm-ed]

A simple, clean and functional redesign of the error activity the ability to quickly restart the app without restarting the CLI. I also tried my best to prettify the stacktrace so it's more readable, any suggestions are welcome regarding it.

• Clicking on the file path prints it in adb logcat and if CLI is still connected, it should show the path in terminal

Most of the changes are related to layout xml files.

A screenshot of how the new ErrorActivity looks:

Compared to:

[edusperoni]

My only concern on this is for very long messages.

For example, if the message itself contains a lot of lines (and maybe even a stacktrace), wouldn't the top bar (red) eventually fill the whole screen?

[ammarahm-ed]

My only concern on this is for very long messages.

For example, if the message itself contains a lot of lines (and maybe even a stacktrace), wouldn't the top bar (red) eventually fill the whole screen?

That is possible but i think it would be rare that the message contains stack trace separately than the one that is already attached to it. The current stack trace is extracted from the long message itself. 🤔

[edusperoni]

Even if it is rare, we should probably consider it (maybe by limiting the top bar height and allowing scroll on it)

[ammarahm-ed]

Agreed, i will try adding something like that and make the top area scrollable.

[ammarahm-ed]

Here's what the activity looks like after latest changes:

https://github.com/NativeScript/android/assets/40239442/2ebdb40b-b23c-4e64-b66f-0fe5fd3f24ae