This PR contains a few bug fixes for bugs which admittedly don't happen very often.
CMake build file syntax fix - this prevented linking any other target with libNativeScript.so (which we don't currently do, but I was trying it for an experiment)
A few fixes that would cause crashes if a Java exception occurred early in initialization of the Runtime or ObjectManager. These crashes prevented seeing the actual cause of the Java exception.
A fix for a race condition that occurred rarely with Workers.
A safety check for DexFactory that prevents inadvertently wiping a folder indiscriminately if passed unexpected data (say, in a test).
Testing most of the PR would depend on being able to simulate a failure early in runtime initialization - we don't currently have the infrastructure for this. Having C++ tests might help in the future.
Description
This PR contains a few bug fixes for bugs which admittedly don't happen very often.
Recommend reviewing commit by commit.
Does your pull request have unit tests?
Testing most of the PR would depend on being able to simulate a failure early in runtime initialization - we don't currently have the infrastructure for this. Having C++ tests might help in the future.