search

NativeScript / android

NativeScript for Android using v8
https://docs.nativescript.org/guide/android-marshalling
Apache License 2.0
524 stars 135 forks source link

fix: correctly load ts_helpers.js in workers #1798

Closed farfromrefug closed 3 months ago

farfromrefug commented 9 months ago

I added tests for this, the submodule needs to be update after the merge in the submodule repo

edusperoni commented 9 months ago

Wouldn't it be better to maybe just add the fields in the configuration objects instead?

farfromrefug commented 9 months ago

@edusperoni not sure what you mean. You know the runtime much better than me. If you think there is a better way go for it !

edusperoni commented 9 months ago

I mean adding on those 2 classes: "DynamicConfiguration" and "StaticConfiguration".

I'll take a look later to see how to best refactor it then

edusperoni commented 7 months ago

@farfromrefug there's a build running with this. Can you confirm again if this solves your issues completely and doesn't break anything on your apps? I've simplified it and added tests, so it should be fine.

farfromrefug commented 3 months ago

@edusperoni i can confirm this works