NativeScript / canvas

Apache License 2.0
88 stars 18 forks source link

Performance!!!!!! #2

Closed triniwiz closed 8 months ago

triniwiz commented 4 years ago
CatchABus commented 2 years ago

@triniwiz I did some tests with Canvas 2D in demo app, specifically with ChartJS sample. I noticed that demo app hangs after multiple draw attempts in canvas and I'm forced to terminate it. My device runs Android 11. It feels like a memory leak occurs.

triniwiz commented 2 years ago

Thanks I'll do some more testing

CatchABus commented 2 years ago

Thanks I'll do some more testing

It looks like it just requires some time, perhaps for garbage collection to take place and I stressed Canvas view a bit too much. Animation made this issue more apparent if I updated chart data too fast.

The first and persistent case that I encountered this was when I tried to update chart during screen orientation change, using resize event.

triniwiz commented 2 years ago

@DimitrisRK If you can try using it with ios and LMK how that behaves

VanderSP commented 1 year ago

bye byeeeeeeeeeeeeeeeee bridge!

triniwiz commented 8 months ago

implemented in https://github.com/NativeScript/canvas/commit/b23b821a5f569faf12187be5eb71e3c5be8743d3