search

NativeScript / canvas

Apache License 2.0
87 stars 18 forks source link

XMLHttpRequest break NS default functionality #87

Open CatchABus opened 2 years ago

CatchABus commented 2 years ago

NativeScript Core already contains a polyfill for XMLHttpRequest here: https://github.com/NativeScript/NativeScript/blob/main/packages/core/xhr/index.ts

Canvas-polyfill uses its own polyfill: https://github.com/NativeScript/canvas/blob/master/packages/canvas-polyfill/async/xhr/TNSXMLHttpRequest.ts

This breaks functionality for libraries that use default NS polyfill (e.g. axios).

triniwiz commented 2 years ago

There are somethings I need to add back into core to ensure the 3rd party libs used with canvas remain functional , that’s the only reason it exists

triniwiz commented 3 weeks ago

Time to to move the extra features into core