NativeScript / docs-v7

Documentation, API reference, and code snippets for NativeScript
https://docs.nativescript.org
Apache License 2.0
446 stars 457 forks source link

feat: No need to show 'Combining Nested Navigation Scenarios' section in Angular guide #1881

Closed s-patompong closed 4 years ago

s-patompong commented 4 years ago

Since there is no Angular code under 'Combining Nested Navigation Scenarios' section, I don't think we should show it under angular doc.

It confused me when I see only header like this without the body:

Screen Shot 2563-03-28 at 19 21 14

PR Checklist

What is the current state of the documentation article?

I see a section called 'Combining Nested Navigation Scenarios' in Angular guide, however I don't see the section's body (describing code, etc.). However, both title and body are shown under normal NativeScript guide.

I think it'd make more sense to bring back this section in Angular guide once the code is ready. For now we better hide it so there is no confusion. Otherwise, we can show it but at least show some text saying things like 'For this section, only NativeScript is available, click here to see it', or something like that.

What is the new state of the documentation article?

I make the webpage hide the 'Combining Nested Navigation Scenarios' section in the Angular guide, it'll still show up as usual under normal NativeScript guide.

cla-bot[bot] commented 4 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. CLA has not been signed by users: @s-patompong. After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

s-patompong commented 4 years ago

@cla-bot check

cla-bot[bot] commented 4 years ago

The cla-bot has been summoned, and re-checked this pull request!

s-patompong commented 4 years ago

Line 259 already has {% endnativescript %}, my code is basically move {% nativescript %} up one line so instead of showing only the header of Combining Nested Navigation Scenarios section, it just hide it totally so user don't get confused when reading Angular doc.