docs(ns-setup-osx.md): Update to follow new brew cask syntax

NativeScript / docs-v7

Documentation, API reference, and code snippets for NativeScript

https://docs.nativescript.org

Apache License 2.0

446 stars 460 forks source link

docs(ns-setup-osx.md): Update to follow new brew cask syntax #1934

Closed mtoohey31 closed 3 years ago

mtoohey31 commented 3 years ago

PR Checklist

[x] The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
[ ] ~~If there is an issue related with this PR, point it out here.~~

What is the current state of the documentation article?

Uses old deprecated brew cask install syntax, see: https://github.com/Homebrew/brew/pull/8899

What is the new state of the documentation article?

Uses new brew install --cask syntax.

~~Fixes/Implements/Closes #[Issue Number].~~

cla-bot[bot] commented 3 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. CLA has not been signed by users: @mtoohey31. After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

mtoohey31 commented 3 years ago

Someone else can feel free to re-contribute these chagnes and open their own pull request, but I'm closing this because I'm not going to sign a CLA in which I must include my mailing address to merge a two line pull request.

NathanaelA commented 3 years ago

@mtoohey31 - If it makes you feel any better, the only people that can see the list is nStudio partners (and most probably don't even know where it exists). :grinning:

This is to cover the legal side of things, since the CLA covers the entire NativeScript org repos. So it might be overkill for docs, but it is primarily because of source code liabilities for all the source code repos.

mtoohey31 commented 3 years ago

Yeah I get that it's for legal reasons and all that and you guys might not really have a choice about it... Still, there's no privacy policy included with it either, but regardless, please feel free to create your own PR to add these changes, new homebrew users might be confused by the error they will run into using this older syntax.