NativeScript / docs-v7

Documentation, API reference, and code snippets for NativeScript
https://docs.nativescript.org
Apache License 2.0
446 stars 460 forks source link

docs: Update SDK root in README #1939

Open goonerify opened 3 years ago

goonerify commented 3 years ago

Command line tools path seems to have changed from $ANDROID_SDK_ROOT/cmdline-tools/tools to $ANDROID_SDK_ROOT/cmdline-tools/cmdline-tools

PR Checklist

What is the current state of the documentation article?

What is the new state of the documentation article?

Fixes/Implements/Closes #[Issue Number].

cla-bot[bot] commented 3 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. CLA has not been signed by users: @goonerify. After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

goonerify commented 3 years ago

@cla-bot check

cla-bot[bot] commented 3 years ago

The cla-bot has been summoned, and re-checked this pull request!

goonerify commented 3 years ago

@cla-bot check

cla-bot[bot] commented 3 years ago

The cla-bot has been summoned, and re-checked this pull request!

rigor789 commented 3 years ago

The reason I haven't merged this yet, is that I couldn't confirm the path is correct - since both on Windows & macOS these don't exist (cmdline-tools) and are located at <SDK_ROOT>/tools/bin