NativeScript / docs-v7

Documentation, API reference, and code snippets for NativeScript
https://docs.nativescript.org
Apache License 2.0
446 stars 457 forks source link

Search on NativeScript with Angular mixes results with core #434

Open m-abs opened 8 years ago

m-abs commented 8 years ago

If I try to search for anything on NativeScript with Angular I get results mixed with NativeScript Core.

For instance searching for "Button" results in a list where the first two results are from Core and the third is the right page: https://docs.nativescript.org/angular/cookbook/ui/button

And the page gives an incorrect example for using the button with angular similar to this issue: https://github.com/NativeScript/docs/issues/390

tjvantoll commented 8 years ago

Thanks @m-abs! Yep and this is a problem outside of the cookbook too. This one might be a bit tricky to solve but we’ll see what we can do. Ping @ErjanGavalji for visibility.

etabakov commented 5 years ago

This issue is still valid, let's keep it open.

etabakov commented 5 years ago

The reason for this bug is that we use the same files and folders structure copied once for the Angular flavour and once for the Core framework. However, part of the files are only valid for one of the frameworks like the example above. Although, these files are not shown in the navigation menu - they still reside in the folder structure and somehow get indexed by the search engines, which leads to the described behaviour.

The solution is to add a cleanup script that goes through the angular and core folder and removes all files that are not relevant to the respective flavour.