NativeScript / docs-v8

https://docs.nativescript.org
29 stars 42 forks source link

png images in tutorials #64

Closed winescout closed 2 years ago

winescout commented 2 years ago

In the tutorials: https://github.com/NativeScript/docs-new/blob/develop/tutorial/plain.md?plain=1#L164 https://github.com/NativeScript/docs-new/blob/develop/tutorial/react.md?plain=1#L171 https://github.com/NativeScript/docs-new/blob/develop/tutorial/angular.md?plain=1#L222 https://github.com/NativeScript/docs-new/blob/develop/tutorial/svelte.md?plain=1#L140 https://github.com/NativeScript/docs-new/blob/develop/tutorial/vue.md?plain=1#L151

Local rareness to images are setup, but those images are not provided in the tutorial.

I did some url hacking to try and find them, but wasn't successful. Can we link to a directory that contains some sample images?

rigor789 commented 2 years ago

The assets can be found in the repo linked at the start (here) https://github.com/NativeScript/tutorials/blob/main/plain-tutorial/app/assets/bookofmormon.png

winescout commented 2 years ago

Thanks rigor. I'll open a new PR pointing this out at that point in the tutorial.

rigor789 commented 2 years ago

Fixed in #65