search

NativeScript / docs-v8

https://docs.nativescript.org
29 stars 42 forks source link

Add missing methods in example for extending Android Activity #81

Closed cdroege closed 2 years ago

cdroege commented 2 years ago

This adds / documents some missing methods that are implemented in the default activity from Nativescript Core.

I had a problem when using the firebase-messaging module and the onNotificationTap handler. That method was never called, when the app was in the background, but it worked, when the app was exited / terminated.

It seemed that the extra data of the Android Intent was empty under this condition and this is used in the firebase module. Adding these two methods to the activity, fixed the issue for me. I hope this fix saves someone else a little bit of debugging.

I am a little bit unsure about line 186, but that line also exists in the default activity.

cla-bot[bot] commented 2 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. CLA has not been signed by users: @cdroege. After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

cdroege commented 2 years ago

@cla-bot check

cla-bot[bot] commented 2 years ago

The cla-bot has been summoned, and re-checked this pull request!