search

NativeScript / docs-v8

https://docs.nativescript.org
29 stars 42 forks source link

Added API description for the Payments: IAP & Subscriptions plugin #84

Closed Ombuweb closed 2 years ago

Ombuweb commented 2 years ago

Added the API section describing all the methods offered by the plugin.

cla-bot[bot] commented 2 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. CLA has not been signed by users: @Nandee89. After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

rigor789 commented 2 years ago

Hi @Ombuweb thanks for the PR, could you open the PR against this file: https://github.com/NativeScript/payments/blob/main/packages/payments/README.md as the contents in this repo are updated daily from the plugin readmes (so your changes here would disappear in ~24hours).

Sorry for the confusion - we plan to make this better when we get the chance...

Ombuweb commented 2 years ago

Hi @rigor789, no problem. I will open it against the other file.

Ombuweb commented 2 years ago

One question @rigor789, does that mean I should use the packages' README.md when contributing to packages docs and docs-new for other contributions?

rigor789 commented 2 years ago

Yep, plugins are separate and just pulled in daily on CI

The rest is managed here